Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I don't think these links speak well for the patches you are talking about. I see a number of instances where the patches are being rejected for legitimate quality issues. It is pointed out that for PowerPC one piece doesn't compile with -Werror, and a bunch of configuration ifdefs no longer build. For ptmx_fops it is pointed out that the old code is better encapsulated and more maintainable if the ops structure gets new members. I did not see this answered. A lot of the diffs insert the "const" keyword in kind of unusual and unconventional places without much explanation, and without looking too deeply I kind of doubt it's the only place it can go to achieve the desired effect. This seems to be confusing reviewers on the thread because they are unused to the pattern. (It's much less of a wtf to see the whole vtable declared const than the individual function pointers, for example.)

Then to get all smug about it and call politics on people for doing a code review, rather than fix the patches or communicate their importance better... They could be doing good work but I don't think they come off well in these threads.



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: