> it's not going to be open source but you will be able to look at the code and send pull requests. So it's very similar to open source in that you can fix bugs and add features if your changes get accepted by Github, but has the limitation that you can't redistribute your changes by creating your own editor based on Atom if Github should not accept your changes.
So it is open source... Just not free software. Get the terms straight, guys.
No, actually this is neither open source nor free software. The Open Source Definition requires the ability to redistribute changes: http://opensource.org/osd
The closest match would be Microsoft's Shared Source licenses.
(Life advice: don't be condescending without also being correct. Actually, you should probably just not be condescending.)
In that case, keep your changes and improvements in your own branch, and don't submit a pull request for them. If you don't want to share it for "free," that's your call.
The whole point is they're trying to have it both ways. They want to benefit from other people's work freely (that's why they're accepting pull requests), but do not want to let others benefit from their work in the same way.
In production and development, open source as a development model promotes a) universal access via free license to a product's design or blueprint, and b) universal redistribution of that design or blueprint, including subsequent improvements to it by anyone. [1]
So it is open source... Just not free software. Get the terms straight, guys.