Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

For anybody too lazy to read through them all, here are some gems:

+ <script language="JavaScript1.2">

Are you sure, like, really really sure, you want JavaScript 1.2?

+var speed=1

please run jslint on your code before submitting a pull request

There are so many errors that JSLint gives up on this code at 39%.

+temp=document.body.scrollTop

You really shouldn't declare a variable without using var - can lead to all sorts of scoping problems.

Oh, good catch! You should submit a pull request to fix this

+<mass of span elements>

There's a couple of redundant span elements here, when you get time, you could optimise this

+ <p align="center" dir="rtl">&nbsp;</p>

It's great that you've made sure that non-breaking space is read right to left, your readers would have been screwed otherwise.

+ $bind_port_p="IyEvdXN...<base64 encoded string>";

    It's going to be hard to comment on these Base64 encoded C and Perl programs in their current form.
    That daemon() function call is going to cause problems on a whole bunch of non-Linux architectures. Solaris doesn't have it for example.
    You should definitely consider supporting IPv6, you can't just assume IPv4 connectivity...
    You're also missing a return at the end of main().
+$auth_pass = "fe3f6d96a1ee06bc5415a5c05540c7a8";

1911990 is not a good password. Your birthday?

Let's hope you didn't use that for your email account, lovestory8976@yahoo.com

can you use a sha512 hash, instead? it's more secure.

+

Hmm the HTML isnt compliant. Please rebase from master, squash the previous commit and resubmit.

Thanks for your invaluable future contributions



Actually, Solaris does have the daemon() function as of Solaris 11:

  http://docs.oracle.com/cd/E19082-01/819-2243/6n4i098sj/index.html


That email account is locked temporarily -- seems like everyone was trying to get in :)


the javsacript version thing really cracks me up.. hhaha


Lol I think that was his email password.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: