I also follow this approach. I just flip the flag on the PR I’m reviewing to off... | Hacker News

Hacker Newsnew | past | comments | ask | show | jobs | submit

yojo 43 days ago | parent | context | favorite | on: Commenting and approving pull requests

I also follow this approach. I just flip the flag on the PR I’m reviewing to off before submitting my approval.

We also have most of our repos set to block if unresolved comments. I think it’s a flag on branch protection rules

namenotrequired 43 days ago [–]

The way my company works, it doesn’t break it. You approve and merge, then any suggestions can be implemented in a next PR

That way the average customer doesn’t need to wait for your code style change or edge case fix

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact