Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

One thing that I've gotten better at, but still find hard, is tolerating CBF in others, when doing code reviews. I'll still call out that something would probably be a good idea (e.g. adding another unit test), but I'll coat that in layers of "but I also understand if that's too much of a hassle".

Half the time folks will still make (something close to) the requested change. The other half they indeed CBF and just merge it as-is. In those latter cases, I'll be slightly disappointed, but I'm also consciously telling myself that honestly, it's often a fine reason, and if it's really important, I can still consider doing the work myself.



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: