Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

"there is absolutely no shame in getting significant comments on a change"

I had a manager who used number of comments received on your PRs as a key metric for code quality (high=bad, low=good), and number of comments you left as a key metric for productivity (leave many comments = good reviewer). It was all numbers based with him-- LOC metrics and the like were huge as well. Every day I worked for him I asked myself "Why do I choose to do this for a living?"



This sounds like hell, and just proves again that wrong metrics are way worse than no metrics at all. You wrote "I had a manager" so I assume you took corrective action :)




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: